Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Sunny/tombstone spec #3103

Merged
merged 27 commits into from
Jan 29, 2019
Merged

R4R: Sunny/tombstone spec #3103

merged 27 commits into from
Jan 29, 2019

Conversation

sunnya97
Copy link
Member

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@sunnya97 sunnya97 requested a review from zramsay as a code owner December 13, 2018 16:27
@codecov
Copy link

codecov bot commented Dec 13, 2018 •
edited
Loading

Codecov Report

Merging #3103 into develop will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3103      +/-   ##
===========================================
- Coverage    59.38%   59.32%   -0.07%     
===========================================
  Files          131      131              
  Lines         9862     9862              
===========================================
- Hits          5857     5851       -6     
- Misses        3632     3638       +6     
  Partials       373      373

@sunnya97 sunnya97 changed the title WIP: Sunny/tombstone spec R4R: Sunny/tombstone spec Dec 17, 2018
@alexanderbez alexanderbez added the T:Docs Changes and features related to documentation. label Dec 18, 2018
cwgoes
cwgoes suggested changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the spec - left comments - can we add more detail on what exactly a tombstone state means in terms of the store? e.g.

  • Validator record left in store, but can never be bonded - essentially special kind of permanent "jail"
  • Maximum slashing amount tracked in case multiple infractions are registered (or maybe this can be post-launch)

Also we probably want to change how we deal with unbonding delegations and redelegations a bit. Presently if we just start unbonding the validator delegators will have unbonding delegations, which can't be converted into redelegations (so they'll have to wait the full unbonding period to delegate their stake to a different validator). That seems suboptimal.

docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
alexanderbez
alexanderbez reviewed Dec 18, 2018
View reviewed changes
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
@sunnya97 sunnya97 mentioned this pull request Jan 2, 2019
Closed
rigelrozanski
rigelrozanski reviewed Jan 3, 2019
View reviewed changes
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tone of this document is a bit funny (ex. use of I) sounds more like ADR - content good however, few comments within

docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
alexanderbez
alexanderbez suggested changes Jan 3, 2019
View reviewed changes
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
@sunnya97 sunnya97 requested a review from ebuchman as a code owner January 6, 2019 05:45
@sunnya97 sunnya97 mentioned this pull request Jan 6, 2019
Merged
5 tasks
cwgoes
cwgoes suggested changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, some first-pass comments still unaddressed I think.

Definitely in favor of the simplicity of implementation!

docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
@sunnya97 sunnya97 mentioned this pull request Jan 10, 2019
Closed
4 tasks
@ebuchman ebuchman mentioned this pull request Jan 11, 2019
Closed
@cwgoes
Copy link
Contributor

cwgoes commented Jan 14, 2019

Bump. Anything anyone else can do to help here @sunnya97?

@jackzampolin
Copy link
Member

I think this needs to get rebased as the tests are failing on this branch.

melekes
melekes approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
@jackzampolin
Copy link
Member

This looks ready to merge once the lint error is fixed @sunnya97 .

WARNING: exec: "golint": executable file not found in $PATH
WARNING: exec: "ineffassign": executable file not found in $PATH
WARNING: exec: "unconvert": executable file not found in $PATH
WARNING: exec: "misspell": executable file not found in $PATH

@cwgoes and @alexanderbez can y'all approve here if the changes look good?

@sunnya97 sunnya97 mentioned this pull request Jan 28, 2019
Closed
5 tasks
cwgoes
cwgoes suggested changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remaining minor comments.

docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Outdated Show resolved Hide resolved
docs/spec/slashing/tombstone.md Show resolved Hide resolved
@jackzampolin
Copy link
Member

Is this ready to go @alexanderbez ?

@alexanderbez
Copy link
Contributor

updated + approved

@cwgoes cwgoes merged commit 3e6ce3d into develop Jan 29, 2019
@cwgoes cwgoes deleted the sunny/tombstone-spec branch January 29, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigelrozanski rigelrozanski rigelrozanski left review comments

@cwgoes cwgoes cwgoes approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@melekes melekes melekes approved these changes

@zramsay zramsay Awaiting requested review from zramsay

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sunnya97 @cwgoes @jackzampolin @alexanderbez @melekes @rigelrozanski